-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a "(no title)" label to links to pages or posts with no title #19528
Conversation
Do you think we could wait with this one until we're able to add the post ID as a prefix there? (#18897 (comment)) |
I'm not sure post ids should necessarily be user facing like that? In the comment you linked to you said
Can you link me to the code that does that? |
@WunderBart why should we wait on merging this? Seems like a minor non-breaking change to me. |
@obenland, I believe the code is here (there are more instances, search for
@draganescu, I thought it was worth a wait because of 2 things:
I'm not considering it a blocker, just a suggestion. We can always add it in another PR! |
Ah I see @WunderBart and I think you do have a point about that edge case. Nevertheless, considering that now the users get a "buggy" no-label-whatsoever menu item, I will merge this and choose, as you also suggested, to come back in a second PR to add the ID for consistency and edge cases. Thank you! :) |
Description
Closes: #18897
How has this been tested?
Tested locally by:
Screenshots
Types of changes
Non breaking change to how default links are created in a navigation block.